[webkit-reviews] review denied: [Bug 84601] [chromium] Add pause and resume support for accelerated css animations. : [Attachment 138371] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied vollick at chromium.org's request
for review:
Bug 84601: [chromium] Add pause and resume support for accelerated css
animations.
https://bugs.webkit.org/show_bug.cgi?id=84601

Attachment 138371: Patch
https://bugs.webkit.org/attachment.cgi?id=138371&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138371&action=review


> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:626
> +void LayerChromium::suspendAnimations(double wallClockTime)

why does this take a wall clock time? who's passing this in to us?

if this is API we control, it should be using monotonicallyIncreasingTime. if
this is being fed in by WebCore, i'd prefer to handle the time rebasing before
it gets in to LayerChromium so we don't have to muck with it there

> Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.cpp:137
> +    // Currently, we only push changes due to pausing and resuming
animations on the main thread.

could you explain why it's OK to delete the code that used to live here?