[webkit-reviews] review granted: [Bug 83980] Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2 : [Attachment 138607] Patch.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Yael
<yael.aharon at nokia.com>'s request for review:
Bug 83980: Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt
webkit2
https://bugs.webkit.org/show_bug.cgi?id=83980

Attachment 138607: Patch.
https://bugs.webkit.org/attachment.cgi?id=138607&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138607&action=review


Why does the test have to be manual?

> Source/WebCore/css/CSSStyleSelector.cpp:152
> +#define ENABLE_FIXED_POSITION_CREATES_STACKING_CONTEXT 1

Just FIXED_POSITION_CREATES_STACKING_CONTEXT please, it's not an ENABLE flag.