[webkit-reviews] review denied: [Bug 83298] getMatchedCSSRules() should return null when the second argument is an unrecognized pseudo-element name : [Attachment 138598] Proposed patch

Tue Apr 24 11:38:00 PDT 2012

Ojan Vafai <ojan at chromium.org> has denied Kulanthaivel Palanichamy
<kulanthaivel at codeaurora.org>'s request for review:
Bug 83298: getMatchedCSSRules() should return null when the second argument is
an unrecognized pseudo-element name
https://bugs.webkit.org/show_bug.cgi?id=83298

Attachment 138598: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=138598&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138598&action=review

The C++ code looks good. I'm not sure about the idl changes though. Someone
more familiar with idl should review that.

With the test, just a few nits. We try to keep as much boilerplate out of the
tests as possible. Makes it easier to see what's going on.

Can you provide a link in the ChangeLog description to the appropriate CSS spec
or www-style discussion for this behavior?

r- to resolve the above couple issues. Then someone with more idl experience
can r+.

>
LayoutTests/fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.htm
l:4
> +<html>
> +<head>
> +<meta charset="utf-8">

You don't need these elements.

>
LayoutTests/fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.htm
l:5
> +<style type="text/css" media="screen">

you don't need the type or media attributes, do you?