[webkit-reviews] review granted: [Bug 84466] Web Inspector: implement "open stylesheet" dialog. : [Attachment 138118] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 84466: Web Inspector: implement "open stylesheet" dialog.
https://bugs.webkit.org/show_bug.cgi?id=84466

Attachment 138118: Patch
https://bugs.webkit.org/attachment.cgi?id=138118&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138118&action=review


> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:657
> +	   // Overriden;

Overriden ->  Overriden in descendants.

> Source/WebCore/inspector/front-end/ResourceUtils.js:63
> +	   if (this.url.indexOf("data:") == 0) {

There was a discussion about using indexOf vs RegExp vs substring for prefix
checks. On long strings RegExp is preferable and given that data: URL may be
quite long, I'd suggest you use a regular expression or substring here.