[webkit-reviews] review denied: [Bug 60931] crash after r86584 due to calling willRemoveWheelEventHandler too many times : [Attachment 101882] Updated patch to address automated review issue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 22 22:28:02 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has denied Rob Bradford <rob at robster.org.uk>'s
request for review:
Bug 60931: crash after r86584 due to calling willRemoveWheelEventHandler too
many times
https://bugs.webkit.org/show_bug.cgi?id=60931
Attachment 101882: Updated patch to address automated review issue
https://bugs.webkit.org/attachment.cgi?id=101882&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101882&action=review
> Source/WebCore/ChangeLog:5
> + Ensure the scrollbars are always removed when the page is detached
> + otherwise unpaired calls to Document::didAddWheelEventHandler and
> + Document::didRemoveWheelEventHandler are made.
This doesn't match the bug summary. Please move the description to below the
bug url followed by a blank line.
Also, you're missing "Reviewed by" below. r- because of this.
More information about the webkit-reviews
mailing list