[webkit-reviews] review denied: [Bug 81319] Web Inspector: Implement the removal of CSS rules : [Attachment 137352] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 18 05:19:37 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 81319: Web Inspector: Implement the removal of CSS rules
https://bugs.webkit.org/show_bug.cgi?id=81319
Attachment 137352: Patch
https://bugs.webkit.org/attachment.cgi?id=137352&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137352&action=review
> Source/WebCore/css/CSSGrammar.y:447
> + before_ruleset ruleset {
This could be a separate patch with a test.
> Source/WebCore/inspector/InspectorCSSAgent.cpp:471
> + return m_styleSheet->insertRuleBefore(m_originalRuleString,
m_anchorId, m_originalRuleTextRange.start, ec);
This implies that you drop the information about the enabled state.
> Source/WebCore/inspector/InspectorStyleSheet.cpp:63
> +struct RuleNode : public RefCounted<RuleNode> {
As we agreed offline, I'd suggest that you expose the stylesheet structure via
the protocol. Otherwise, you logic for insertion of a rule into a given place
of the stylesheet is only accessible as an undo operation for the delete rule.
More information about the webkit-reviews
mailing list