[webkit-reviews] review requested: [Bug 84232] Add PassThis=* to support the callbacks which requires to pass "this" value. : [Attachment 137671] Updated Patch

[bugzilla-daemon at webkit.org]

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 84232: Add PassThis=* to support the callbacks which requires to pass
"this" value.
https://bugs.webkit.org/show_bug.cgi?id=84232

Attachment 137671: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=137671&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
> For GObject/CPP/ObjC, let's leave it as-is. If it caused a problem when we
actually use [PassThis] in some IDL file, let's add [PassThis] to the Skip()
methods in CodeGenerator{GObject,ObjC,CPP}.pm.

Currently it doesn't creates ant problem in any of GObject,ObjC,CPP these
bindings so we can leave it as-is.

> Maybe [PassThisToCallback] would be more descriptive. It's up to you though.

Right..

> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2693
> >		     push(@args, GetNativeType($param->type) . " " .
$param->name);
> 
> Nit: You can use $paramName.
Done 

> > Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp:154
> > +	 ASSERT(thisClassParam);

> Writing both ASSERT() and if(!...) sounds strange. (I know you just copied
the existing code though.)

Hmm just copied form the v8 mutation custom code.
 
> - If thisClassParam should be always true, just put ASSERT() and remove
if(!...).

thisClassParam should be always true. So lets ASSERT(thisClassParam);

Thanks for commnets..:)