[webkit-reviews] review granted: [Bug 83848] Add size_t versions of multiplication and division operators to FractionalLayoutUnit : [Attachment 137222] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 83848: Add size_t versions of multiplication and division operators to
FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=83848

Attachment 137222: Patch
https://bugs.webkit.org/attachment.cgi?id=137222&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137222&action=review


>>> Source/WebCore/platform/FractionalLayoutUnit.h:41
>>> +#endif
>> 
>> This feels like something which belongs in a more central place.  I'm not
sure.  MathExtras?  Maybe there is some other header in wtf in which thsi would
make sense?  Is this really the only place we have this trouble?
> 
> I haven't found any other places where we have a function that can either
take an unsigned int or a size_t, generally we tend to use one or the other.

I haven't heard any strong objections to keeping the #define here. The only
people who commented felt like it may belong somewhere else but nothing
substantial (Eric thought of MathExtras.h, I thought about Platform.h but it
felt clunky). Based on your assessment, I feel like it's fine to keep it here
for now. If someone objects, it can moved appropriately.