[webkit-reviews] review denied: [Bug 82301] [EFL] LayoutTestController does not implement callShouldCloseOnWebView : [Attachment 134249] Improved patch based on Grzegorz Czajkowski's comment.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 17 10:18:19 PDT 2012
Martin Robinson <mrobinson at webkit.org> has denied review:
Bug 82301: [EFL] LayoutTestController does not implement
callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=82301
Attachment 134249: Improved patch based on Grzegorz Czajkowski's comment.
https://bugs.webkit.org/attachment.cgi?id=134249&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134249&action=review
Looks good, just giving an r- because of the funky changelogs.
> LayoutTests/ChangeLog:529
> +2012-03-27 Christophe Dumez <christophe.dumez at intel.com>
> +
> + EFL's LayoutTestController does not implement
callShouldCloseOnWebView
> + https://bugs.webkit.org/show_bug.cgi?id=82301
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + Implement callShouldCloseOnWebView in EFL's LayoutTestController by
The changelog is in the wrong place here. This will prevent the patch from
landing properly with the cq, I think.
More information about the webkit-reviews
mailing list