[webkit-reviews] review denied: [Bug 83772] [BlackBerry] Set referrer for plugin load if needed. : [Attachment 136902] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 83772: [BlackBerry] Set referrer for plugin load if needed.
https://bugs.webkit.org/show_bug.cgi?id=83772

Attachment 136902: Patch
https://bugs.webkit.org/attachment.cgi?id=136902&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136902&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests, initial upstream of BlackBerry porting.

plePlease say what it fixes, and why others might not need this.

> Source/WebCore/plugins/PluginView.cpp:127
> +static void setReferrerIfNeeded(FrameLoaderRequest request, const Frame*
parentFrame)
> +{
> +#if PLATFORM(BLACKBERRY)
> +    if (!SecurityPolicy::shouldHideReferrer(request.resourceRequest().url(),
parentFrame->document()->baseURL()))
> +	  
request.resourceRequest().setHTTPReferrer(parentFrame->loader()->outgoingReferr
er());
> +#endif
> +}

use param_unused in a #else block, please.