[webkit-reviews] review requested: [Bug 74929] webkit-patch apply-attachment is very slow for big patches : [Attachment 136911] show.xml.tmpl

[bugzilla-daemon at webkit.org]

Zoltan Arvai <zarvai at inf.u-szeged.hu> has asked  for review:
Bug 74929: webkit-patch apply-attachment is very slow for big patches
https://bugs.webkit.org/show_bug.cgi?id=74929

Attachment 136911: show.xml.tmpl
https://bugs.webkit.org/attachment.cgi?id=136911&action=review

------- Additional Comments from Zoltan Arvai <zarvai at inf.u-szeged.hu>
add bugs.webkit.org/template/en/custom/bug/show.xml.tmpl :

I replaced this section 

 [% IF displayfields.attachmentdata %]
 <data encoding="base64">[% a.data FILTER base64 %]</data>

with this content:

 [% IF displayfields.attachmentdata %]
 [%# Return URL of attachment instead of data #%]
 <url>[% urlbase FILTER uri FILTER html %]attachment.cgi?id=[% a.id %]</url>

Is it a valid solution for this problem? Is any other modification necessary to
apply the new template file?