[webkit-reviews] review granted: [Bug 83507] Clean up LayoutUnit usage in DOMNodeHighlighter : [Attachment 136309] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 83507: Clean up LayoutUnit usage in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=83507

Attachment 136309: Patch
https://bugs.webkit.org/attachment.cgi?id=136309&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136309&action=review


> Source/WebCore/ChangeLog:11
> +	   Ensuring DOMNodeHighlighter uses pixel snapping that matches that
done in the RenderTree. Changes include:
> +	   - Reverting drawSubstring to use an IntPoint with pixel snapped
values instead of a LayoutPoint.
> +	   - Reverting borderBox to an IntRect since it's in absolute
coordinates. See https://trac.webkit.org/wiki/LayoutUnit.
> +	   - Frames are still laid out with integers. Cleaning up
mainFrameOffset to reflect that.

Nicely stated!