[webkit-reviews] review granted: [Bug 83497] Replace numeric_limits<LayoutUnit>::min/max with constants : [Attachment 136298] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 83497: Replace numeric_limits<LayoutUnit>::min/max with constants
https://bugs.webkit.org/show_bug.cgi?id=83497

Attachment 136298: Patch
https://bugs.webkit.org/attachment.cgi?id=136298&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136298&action=review


>>> Source/WebCore/ChangeLog:10
>>> +	     switch to subpixel layout.
>> 
>> Why does this make the switch easier?
> 
> It allows us to use an abstraction to represent the min/max values for ints
(for now) and FractionalLayoutUnits (after the switch). We originally planed to
just leave it as is and define numeric_limits for FractionalLayoutUnit but that
was shoot down during the initial review of FractionalLayoutUnit.h as it would
involve declaring it in the std namespace.

OK.

I think I might prefer LayoutUnit::maxValue and LayoutUnit::zeroValue, etc. 
But I understand that's impractical at this juncture.