[webkit-reviews] review granted: [Bug 81573] Add support for [ArrayClass] and use that on NodeList : [Attachment 135951] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 6 15:02:46 PDT 2012
Adam Barth <abarth at webkit.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 81573: Add support for [ArrayClass] and use that on NodeList
https://bugs.webkit.org/show_bug.cgi?id=81573
Attachment 135951: Patch
https://bugs.webkit.org/attachment.cgi?id=135951&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135951&action=review
This looks great. I'm glad that we're making this change. Don't forget to
update the IDL documentation. Thanks!
> Source/WebCore/bindings/v8/V8HiddenPropertyName.h:40
> V(objectPrototype) \
> + V(arrayPrototype) \
I don't think we're using these anymore. We can probably just delete them now
that we're using V8BindingPerContextData.
More information about the webkit-reviews
mailing list