[webkit-reviews] review granted: [Bug 80200] Add transfer map argument to Intent constructor : [Attachment 136068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 15:04:55 PDT 2012


Adam Barth <abarth at webkit.org> has granted Greg Billock <gbillock at google.com>'s
request for review:
Bug 80200: Add transfer map argument to Intent constructor
https://bugs.webkit.org/show_bug.cgi?id=80200

Attachment 136068: Patch
https://bugs.webkit.org/attachment.cgi?id=136068&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136068&action=review


> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1335
> +    WebMessagePortChannelArray* ports =
request.intent().messagePortChannelsRelease();
>      m_currentRequest = request;
> +    if (ports) {
> +	   printf("Have %zu ports\n", ports->size());
> +	   for (size_t i = 0; i < ports->size(); ++i)
> +	       (*ports)[i]->destroy();

I'm still slightly worried that other clients of this function will have memory
leaks, but I'm not sure what we can do about it.


More information about the webkit-reviews mailing list