[webkit-reviews] review denied: [Bug 83330] Allow certain Char events in fullscreen : [Attachment 135938] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Cem Kocagil
<cem.kocagil+webkit at gmail.com>'s request for review:
Bug 83330: Allow certain Char events in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=83330

Attachment 135938: Patch
https://bugs.webkit.org/attachment.cgi?id=135938&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135938&action=review


It is expected behavior that keypress events (corresponding to Char) have a
character code, but no virtual key code.

It's quite unfortunate that information about key bindings is hardcoded here.
In fact, existing code below makes me quite suspicious (why VK_BACK? why
VK_OEM_1?)

> Source/WebCore/page/EventHandler.cpp:2728
> +	   char character = keyEvent.text()[0];

This character is Unicode, so converting to char loses high bits. Also, this
should check that length of text is 1.