[webkit-reviews] review denied: [Bug 83322] [Qt] Fix WebKit1 build with V8 : [Attachment 136034] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 11:16:28 PDT 2012


Adam Barth <abarth at webkit.org> has denied Balazs Kelemen <kbalazs at webkit.org>'s
request for review:
Bug 83322: [Qt] Fix WebKit1 build with V8
https://bugs.webkit.org/show_bug.cgi?id=83322

Attachment 136034: Patch
https://bugs.webkit.org/attachment.cgi?id=136034&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136034&action=review


> Source/WebCore/bindings/v8/ScriptState.cpp:138
> +#if PLATFORM(QT)
> +    // The v8 version in qtjsbackend does not have this API yet.
> +    return true;
> +#else

Can we update the V8 version in qtjsbackend?  This code is necessary for
security.  You need to have a version of V8 that supports this feature in order
when using a version of WebKit that contains this code.


More information about the webkit-reviews mailing list