[webkit-reviews] review denied: [Bug 82757] [Chromium] defaultDeviceScaleFactor != 0 should set deviceScaleFactor = defaultDeviceScaleFactor in the absence of a viewport tag for debugging purposes : [Attachment 135356] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Tim Dresser
<tdresser at chromium.org>'s request for review:
Bug 82757: [Chromium] defaultDeviceScaleFactor != 0 should set
deviceScaleFactor = defaultDeviceScaleFactor in the absence of a viewport tag
for debugging purposes
https://bugs.webkit.org/show_bug.cgi?id=82757

Attachment 135356: Patch
https://bugs.webkit.org/attachment.cgi?id=135356&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135356&action=review


> Source/WebKit/chromium/tests/WebFrameTest.cpp:34
> +#include "FrameView.h"

please avoid reaching into WebCore if you can help it.

> Source/WebKit/chromium/tests/WebFrameTest.cpp:181
> +    webViewImpl->resize(WebSize(viewportWidth, viewportHeight));

Why do you need to use WebViewImpl here?

> Source/WebKit/chromium/tests/WebFrameTest.cpp:185
> +    webViewImpl->mainFrameImpl()->frameView()->layout();

just call WebWidget::layout()?	WebView inherits from WebWidget