[webkit-reviews] review requested: [Bug 81186] REGRESSION (r103859): Cannot write a word with Korean double consonant : [Attachment 135918] A quick fix v1 (applied a comment)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 5 15:40:00 PDT 2012
Hironori Bono <hbono at chromium.org> has asked for review:
Bug 81186: REGRESSION (r103859): Cannot write a word with Korean double
consonant
https://bugs.webkit.org/show_bug.cgi?id=81186
Attachment 135918: A quick fix v1 (applied a comment)
https://bugs.webkit.org/attachment.cgi?id=135918&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,
Many thanks for your review and investigation. I have tested your solution and
verified it also fixes this issue. Even though I do not have any ideas how to
write a layout test for this issue, would it be possible to review the updated
one?
Regards,
Hironori Bono
(In reply to comment #8)
> (From update of attachment 133184 [details])
> It looks like the problem is that the fake mouse event goes through
mouseMovedInternal:, which does [[self inputContext] handleEvent:theEvent].
Since we don’t need the extra handling in -mouseMoved:, I think
-postFakeMouseMovedEventForFlagsChangedEvent: should just change to do
>
> NativeWebMouseEvent webEvent(fakeEvent, self);
> _data->_page->handleMouseEvent(webEvent);
More information about the webkit-reviews
mailing list