[webkit-reviews] review denied: [Bug 83108] Web Inspector: JSC Crash inspecting node with object event listener : [Attachment 135493] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 83108: Web Inspector: JSC Crash inspecting node with object event listener
https://bugs.webkit.org/show_bug.cgi?id=83108

Attachment 135493: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=135493&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=135493&action=review


> Source/WebCore/bindings/js/ScriptEventListener.cpp:-103
> -    JSLock lock(SilenceAssertionsOnly);

Why did you remove this lock?

> Source/WebCore/bindings/js/ScriptEventListener.cpp:125
> +    if (!isJSFunction(jsObject))

No need to check isJSFunction. jsCast<T> will return 0 if the cast fails.