[webkit-reviews] review granted: [Bug 83042] WebSocketServer: Honour WebSocketFrame::masked in makeFrameData : [Attachment 135348] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 83042: WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
https://bugs.webkit.org/show_bug.cgi?id=83042

Attachment 135348: Patch
https://bugs.webkit.org/attachment.cgi?id=135348&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135348&action=review


> Source/WebCore/Modules/websockets/WebSocketFrame.cpp:157
> +    char& firstByte = frameData.at(0);
> +    char& secondByte = frameData.at(1);
> +    firstByte = (final ? finalBit : 0) | (compress ? compressBit : 0) |
opCode;

The variable firstByte looks unnecessary.
  frameData.at(0) = (final ? ...