[webkit-reviews] review granted: [Bug 82090] [JSC]ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order : [Attachment 134437] The fix

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 82090: [JSC]ArrayBufferView and its ArrayBuffer are appended to object pool
in wrong order
https://bugs.webkit.org/show_bug.cgi?id=82090

Attachment 134437: The fix
https://bugs.webkit.org/attachment.cgi?id=134437&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134437&action=review


Looks good. Couple of minor typos in the ChangeLogs; feel free to fix upon
landing. r=me

> LayoutTests/ChangeLog:5
> +	   The implementation of structured cloning algorithm
(http://www.w3.org/TR/html5/common-dom-interfaces.html#internal-structured-clon
ing-algorithm)

Perhaps this ChangeLog message shouldn't duplicate that in WebCore?

> LayoutTests/ChangeLog:15
> +	   the ArrayBufferView and then to underlying ArrayBuffer; however on
deserialziation the ids were assigned another way round.

typo: deserialization

> LayoutTests/ChangeLog:17
> +	   This patch fixes that by assigning the id first to ArrayBuffer and
then to ArrayBufferView, and addes corresponding test cases.

typo: adds

> Source/WebCore/ChangeLog:15
> +	   the ArrayBufferView and then to underlying ArrayBuffer; however on
deserialziation the ids were assigned another way round.

typo (see above)

> Source/WebCore/ChangeLog:17
> +	   This patch fixes that by assigning the id first to ArrayBuffer and
then to ArrayBufferView, and addes corresponding test cases.

typo (see above)