[webkit-reviews] review granted: [Bug 81114] ASSERT(!needsLayout()) in FrameView::paintContents() with multiple nested iframes, when frame flattening is on : [Attachment 135337] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 81114: ASSERT(!needsLayout()) in FrameView::paintContents() with multiple
nested iframes, when frame flattening is on
https://bugs.webkit.org/show_bug.cgi?id=81114

Attachment 135337: Patch
https://bugs.webkit.org/attachment.cgi?id=135337&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=135337&action=review


> Source/WebCore/ChangeLog:9
> +	   When frame flattening is on, childframes try to mark ancestors dirty
to be able to restart
> +	   layout from mainframe. When marking ancestor fails, childframe
layout needs to continue normally.

You should explain what the case where marking ancestors fails is and why it is
not an error.

> LayoutTests/platform/chromium/test_expectations.txt:724
>  WONTFIX SKIP : fast/frames/flattening = TIMEOUT
> +WONTFIX SKIP :
http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html =
TIMEOUT

Please check that other platforms are ok with this when landing.