[webkit-reviews] review granted: [Bug 68526] Web Inspector: RawSourceCode could be mapped to several UISourceCodes. : [Attachment 109027] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 68526: Web Inspector: RawSourceCode could be mapped to several
UISourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=68526

Attachment 109027: Patch
https://bugs.webkit.org/attachment.cgi?id=109027&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109027&action=review


>>> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:462
>>> +	     var uiLocation =
this._rawSourceCode.sourceMapping.rawLocationToUILocation(this._callFrame.locat
ion);
>> 
>> Again, use rawLocationToUILocation. I don't get your FIXME in the
RawSourceCode suggesting the opposite. Are you expecting RawSourceCode to lose
this._sourceMapping member?
> 
> FIXME in the RawSourceCode suggests that conversion methods should be a part
of SourceMapping interface because sometimes RawSourceCode don't have source
mapping right after creation (e.g. formatting is in progress).

Please add FIXME suggesting doing rawSourceCode.toUILocation()