[webkit-reviews] review granted: [Bug 68891] Web Inspector: add compiler source mapping support to RawSourceCode. : [Attachment 109138] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 30 04:46:50 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 68891: Web Inspector: add compiler source mapping support to RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=68891
Attachment 109138: Patch
https://bugs.webkit.org/attachment.cgi?id=109138&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109138&action=review
> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:285
> + var rawLocation =
uiSourceCode.rawSourceCode.sourceMapping.uiLocationToRawLocation(uiSourceCode,
lineNumber);
Please put FIXME suggesting doing uiSourceCode.toRawLocation().
More information about the webkit-reviews
mailing list