[webkit-reviews] review denied: [Bug 69018] add more stack dumping methods : [Attachment 109181] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 69018: add more stack dumping methods
https://bugs.webkit.org/show_bug.cgi?id=69018

Attachment 109181: Patch
https://bugs.webkit.org/attachment.cgi?id=109181&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109181&action=review


> Source/JavaScriptCore/wtf/Assertions.cpp:77
> +    if (mangledName) {
> +	   char* cxaDemangled = abi::__cxa_demangle(mangledName, 0, 0, 0);
> +	   if (cxaDemangled) {
> +	       CString demangledName = cxaDemangled;
> +	       cxaDemangled = 0;
> +	       return demangledName;
> +	   }
> +	   return CString(mangledName);

CString is a good choice, since want to pass the string to printf.

However, you have a memory leak here. You need to free the buffer returned by
abi::__cxa_demangle. Assigning 0 to it is meaningless.