[webkit-reviews] review denied: [Bug 69058] DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT : [Attachment 109153] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Yuqiang Xian
<yuqiang.xian at intel.com>'s request for review:
Bug 69058: DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69058

Attachment 109153: patch
https://bugs.webkit.org/attachment.cgi?id=109153&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109153&action=review


> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:55
> +#if CPU(X86) && COMPILER(GCC)

I don't think GCC is the right test here. It will definitely be wrong for
people building with clang. But I think it may also be wrong for people
building with GCC on non-cdecl platforms, since cdecl is a property of the
platform ABI, not the compiler.

I'd suggest (OS(DARWIN) || OS(LINUX)) here.