[webkit-reviews] review denied: [Bug 68526] Web Inspector: RawSourceCode could be mapped to several UISourceCodes. : [Attachment 109027] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 28 22:46:14 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 68526: Web Inspector: RawSourceCode could be mapped to several
UISourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=68526
Attachment 109027: Patch
https://bugs.webkit.org/attachment.cgi?id=109027&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109027&action=review
> LayoutTests/inspector/debugger/raw-source-code.html:106
> var rawSourceCode = createRawSourceCode(script, null);
You probably need a new test for this functionality.
> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:462
> + var uiLocation =
this._rawSourceCode.sourceMapping.rawLocationToUILocation(this._callFrame.locat
ion);
Again, use rawLocationToUILocation. I don't get your FIXME in the RawSourceCode
suggesting the opposite. Are you expecting RawSourceCode to lose
this._sourceMapping member?
More information about the webkit-reviews
mailing list