[webkit-reviews] review denied: [Bug 68997] Web Inspector: update call frame location when source mapping is changed. : [Attachment 109009] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 68997: Web Inspector: update call frame location when source mapping is
changed.
https://bugs.webkit.org/show_bug.cgi?id=68997

Attachment 109009: Patch
https://bugs.webkit.org/attachment.cgi?id=109009&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109009&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:378
> +	      
this._executionRawSourceCode.removeEventListener(WebInspector.RawSourceCode.Eve
nts.SourceMappingUpdated, this._dispatchExecutionLineChanged, this);

I don't think the concept of the executionRawSourceCode should exist. Execution
line for us is the line of the call frame, the one from the UI.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-445
> -    get isInternalScript()

You should mention this change in the ChangeLog

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:509
> +	  
this._rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.SourceMa
ppingUpdated, updatePlacard, this);

Why aren't we using linkifyLocation here?