[webkit-reviews] review denied: [Bug 69018] add more stack dumping methods : [Attachment 109057] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 69018: add more stack dumping methods
https://bugs.webkit.org/show_bug.cgi?id=69018

Attachment 109057: Patch
https://bugs.webkit.org/attachment.cgi?id=109057&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109057&action=review


> Source/JavaScriptCore/wtf/Assertions.cpp:169
> +void WTFSaveBacktrace(void** stack, int* size)

"WTFGetBacktrace" is a better name to indicate and out parameter.

> Source/JavaScriptCore/wtf/Assertions.cpp:181
> +// ugly: returns string allocated by malloc, which must be freed.
> +char* WTFPrettifyStackframe(void* addr)

Please return a PassOwnPtr instead.

> Source/JavaScriptCore/wtf/Assertions.cpp:193
> +	   char* mallocedName = (char*) malloc(strlen(mangledName)+1);

Please use fastMalloc instead of malloc. Please use C++ cast instead of C cast.


> Source/JavaScriptCore/wtf/Assertions.cpp:194
> +	   strcpy(mallocedName, mangledName);

Please use strncpy.