[webkit-reviews] review granted: [Bug 44886] Reflected attribute input.size wraps on negative values (Chrome), or returns them (Safari) : [Attachment 108965] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antaryami Pandia
<xqb748 at motorola.com>'s request for review:
Bug 44886: Reflected attribute input.size wraps on negative values (Chrome), or
returns them (Safari)
https://bugs.webkit.org/show_bug.cgi?id=44886

Attachment 108965: Patch
https://bugs.webkit.org/attachment.cgi?id=108965&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108965&action=review


> LayoutTests/fast/dom/HTMLInputElement/input-size-attribute.html:20
> +input.setAttribute("size", "-1");
> +shouldBe("input.size", "20");

There’s another way to write this that makes the test output clearer:

    shouldBe("input.setAttribute('size', '-1'); input.size", "20");

By putting the work inside the macro you can actually see it in the test
output. We can always patch it to that new style after landing the initial
version, though.