[webkit-reviews] review granted: [Bug 68508] [GTK] Add WebKitError to GTK+ WebKit2 API : [Attachment 108993] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 28 08:00:55 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 68508: [GTK] Add WebKitError to GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=68508

Attachment 108993: Updated patch
https://bugs.webkit.org/attachment.cgi?id=108993&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108993&action=review


> Source/WebKit2/GNUmakefile.am:1019
> +			--fprod "\n/* enumerations from \"@filename@\" */" \

Please use: Enumerations from \"@filename@\."

> Source/WebKit2/UIProcess/API/gtk/WebKitError.cpp:2
> + * Copyright (C) 2008 Luca Bruno <lethalman88 at gmail.com>

This should probably be our copyright.

> Source/WebKit2/UIProcess/API/gtk/WebKitError.cpp:29
> +GQuark webkit_network_error_quark(void)
> +{
> +    return g_quark_from_static_string(WebCore::errorDomainNetwork);
> +}

Please fix the style errors here. No need to have a "void" for an empty
argument list.

> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:2
> + * Copyright (C) 2008 Luca Bruno <lethalman88 at gmail.com>

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:28
> +#define WEBKIT_NETWORK_ERROR webkit_network_error_quark ()

Is this a work-around for some issue or is it standard practice. If it's just a
work-around I think we should just use webkit_network_error_quark everywhere.

> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:35
> +    WEBKIT_NETWORK_ERROR_FAILED		= 399,
> +    WEBKIT_NETWORK_ERROR_TRANSPORT		= 300,
> +    WEBKIT_NETWORK_ERROR_UNKNOWN_PROTOCOL	= 301,
> +    WEBKIT_NETWORK_ERROR_CANCELLED		= 302,
> +    WEBKIT_NETWORK_ERROR_FILE_DOES_NOT_EXIST = 303

Please don't unalign these.


More information about the webkit-reviews mailing list