[webkit-reviews] review denied: [Bug 68936] [Chromium] Seperate GTK specific Gyp rules from X11 Gyp rules : [Attachment 108899] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 68936: [Chromium] Seperate GTK specific Gyp rules from X11 Gyp rules
https://bugs.webkit.org/show_bug.cgi?id=68936

Attachment 108899: Patch
https://bugs.webkit.org/attachment.cgi?id=108899&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108899&action=review


> Source/WebCore/ChangeLog:14
> +	   No new tests. (OOPS!)

Remove this line.

> Source/WebCore/WebCore.gyp/WebCore.gyp:-1373
> -	       ['include', 'platform/chromium/KeyCodeConversionGtk\\.cpp$'],

Why can't we delete KeyCodeConversionGtk.cpp?

> Source/WebCore/WebCore.gyp/WebCore.gyp:1532
> +	   ['use_x11 == 0', {
>	     'sources/': [
>	       ['exclude', '(Gtk|Linux)\\.cpp$'],
>	       ['exclude', 'Harfbuzz[^/]+\\.(cpp|h)$'],
>	     ],
>	   }],

Can we move this to an else clause of the use_x11 == 1 above?

> Source/WebCore/WebCore.gyp/WebCore.gyp:1635
> +	   ['use_x11 == 0', {
>	     'sources/': [
>	       ['exclude', '(Gtk|Linux)\\.cpp$'],
>	     ],

This one is weird.  Should we split the Gtk and Linux cases into two
conditions?

> Source/WebCore/WebCore.gyp/WebCore.gyp:1765
> -	   ['toolkit_uses_gtk == 0', {
> +	   ['use_x11 == 0', {
>	     'sources/': [
>	       ['exclude', '(Gtk|Linux)\\.cpp$'],

ditto.

> Source/WebKit/chromium/ChangeLog:8
> +	   public/linux/WebFontInfo.h is a copy of public/gtk/WebFontInfo.h  
> +
> +	   The original file will be deleted once the appropriate changes have
landed in Chromium.

One way to make this more clear is to have the old header be a forwarding
header.  It would avoid the confusion about having 2 identical headers in the
tree.