[webkit-reviews] review requested: [Bug 68593] DFG JIT should infer which uses of a variable are not aliased : [Attachment 108904] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 27 14:53:28 PDT 2011


Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 68593: DFG JIT should infer which uses of a variable are not aliased
https://bugs.webkit.org/show_bug.cgi?id=68593

Attachment 108904: the patch
https://bugs.webkit.org/attachment.cgi?id=108904&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
This undoes a 2% speed-up that I had seen on my laptop, but that was not seen
on arewefastyet.com.  I investigated this to death, and found that the DFG does
exactly the same thing, in exactly the same order, on the benchmark that has
the 14% fluctuation.  Compile time is definitely not an issue.	I'm guessing
that the fluctuation that I had seen (14% win after getting rid of static
predictions, and a 14% slow-down with this patch) was just some kind of
systematic noise and I'm inclined to ignore it.


More information about the webkit-reviews mailing list