[webkit-reviews] review granted: [Bug 68746] wtf/BitVector.h has a variety of bugs which manifest when the vector grows beyond 63 bits : [Attachment 108570] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 68746: wtf/BitVector.h has a variety of bugs which manifest when the vector
grows beyond 63 bits
https://bugs.webkit.org/show_bug.cgi?id=68746

Attachment 108570: the patch
https://bugs.webkit.org/attachment.cgi?id=108570&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108570&action=review


r=me, but it would be worth considering whether ensureSize() should be inline
or outline before landing

> Source/JavaScriptCore/wtf/BitVector.h:79
> -    void ensureSize(size_t numBits)
> -    {
> -	   if (numBits <= size())
> -	       return;
> -	   resizeOutOfLine(numBits);
> -    }
> +    void ensureSize(size_t numBits);

Do you really want to take ensureSize out of line? you already have
resizeOutOfLine so it seems overkill to hoist the entire function out