[webkit-reviews] review requested: [Bug 68742] [chromium] Update VideoLayerChromium textures after texture resources are reclaimed : [Attachment 108564] Patch

[bugzilla-daemon at webkit.org]

Vangelis Kokkevis <vangelis at chromium.org> has asked  for review:
Bug 68742: [chromium] Update VideoLayerChromium textures after texture
resources are reclaimed
https://bugs.webkit.org/show_bug.cgi?id=68742

Attachment 108564: Patch
https://bugs.webkit.org/attachment.cgi?id=108564&action=review

------- Additional Comments from Vangelis Kokkevis <vangelis at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108564&action=review


> Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:86
> +    if (m_dirtyRect.isEmpty() && texturesValid())

Don't we need to reserve the textures to prevent them from being recycled
before we get to use them?

> Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:150
> +    for (unsigned i = m_planes; i < MaxPlanes; ++i)

This can also be moved to updateCompositorResources() and only be run if the
number of planes changed.