[webkit-reviews] review requested: [Bug 67443] Clean up CachedResource::load() : [Attachment 108175] Fix a couple of failing tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 21 10:23:31 PDT 2011


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 67443: Clean up CachedResource::load()
https://bugs.webkit.org/show_bug.cgi?id=67443

Attachment 108175: Fix a couple of failing tests
https://bugs.webkit.org/attachment.cgi?id=108175&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Two changes from previous version:
1. Call releaseResources() instead of cancel() in ResourceLoader::init(). 
Since we haven't called willSendRequest() yet, it's not really a cancel, and
not all clients play nicely with cancel() before willSendRequest().
2. In SubresourceLoader::create(), call DocumentLoader::addSubresourceLoader()
after init(), instead of before.  If we fail a security check and exit early,
we won't ever call removeSubresourceLoader(), resulting in load events never
firing.

Sorry for the long delay in getting a new patch out.


More information about the webkit-reviews mailing list