[webkit-reviews] review granted: [Bug 68492] Clean up CSS Counter code : [Attachment 108088] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 21 10:22:45 PDT 2011
Tony Chang <tony at chromium.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 68492: Clean up CSS Counter code
https://bugs.webkit.org/show_bug.cgi?id=68492
Attachment 108088: Patch
https://bugs.webkit.org/attachment.cgi?id=108088&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108088&action=review
> Source/WebCore/css/CSSParser.cpp:3675
> short ls = 0;
Nit: While we're here, this should probably be an int since CSSParserValue::id
is an int and we should use a better variable name than ls (like cssValueID or
listStyleID).
More information about the webkit-reviews
mailing list