[webkit-reviews] review requested: [Bug 68442] [Qt] QTouchWebView missing signal tests for loadProgress : [Attachment 108006] TouchWebView loadProgress signal test

[bugzilla-daemon at webkit.org]

Gopal Raghavan <gopal.1.raghavan at nokia.com> has asked  for review:
Bug 68442: [Qt] QTouchWebView missing signal tests for loadProgress
https://bugs.webkit.org/show_bug.cgi?id=68442

Attachment 108006: TouchWebView loadProgress signal test
https://bugs.webkit.org/attachment.cgi?id=108006&action=review

------- Additional Comments from Gopal Raghavan <gopal.1.raghavan at nokia.com>
Adding signal tests for TouchWebView.
This is very similar to DesktopWebView (68280).
Here is the test results:

********* Start testing of qmltests *********
Config: Using QTest library 5.0.0, Qt 5.0.0
PASS   : DesktopWebViewLoadProgress::initTestCase()
QWARN  : DesktopWebViewLoadProgress::test_loadProgress() QSocketNotifier:
socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : DesktopWebViewLoadProgress::test_loadProgress()
PASS   : DesktopWebViewLoadProgress::cleanupTestCase()
PASS   : DesktopWebViewLoadProgressSignal::initTestCase()
QWARN  : DesktopWebViewLoadProgressSignal::test_loadProgressSignal()
QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : DesktopWebViewLoadProgressSignal::test_loadProgressSignal()
PASS   : DesktopWebViewLoadProgressSignal::cleanupTestCase()
QWARN  : qmltests::UnknownTestFunc() QSocketNotifier: socket notifiers cannot
be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : DesktopWebViewNavigationPolicyForUrl::initTestCase()
QWARN  : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy()
QObject::startTimer: timers cannot be started from another thread
PASS   : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy()
PASS   : DesktopWebViewNavigationPolicyForUrl::test_usePolicy()
PASS   : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase()
PASS   : DesktopWebViewProperties::initTestCase()
QWARN  : DesktopWebViewProperties::test_title() QSocketNotifier: socket
notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : DesktopWebViewProperties::test_title()
PASS   : DesktopWebViewProperties::test_url()
PASS   : DesktopWebViewProperties::cleanupTestCase()
PASS   : TouchWebViewLoad::initTestCase()
QWARN  : TouchWebViewLoad::test_load() QSocketNotifier: socket notifiers cannot
be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoad::test_load()
PASS   : TouchWebViewLoad::cleanupTestCase()
PASS   : TouchWebViewLoad::initTestCase()
QWARN  : TouchWebViewLoad::test_loadNegativeSizeView() QSocketNotifier: socket
notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoad::test_loadNegativeSizeView()
PASS   : TouchWebViewLoad::cleanupTestCase()
PASS   : TouchWebViewLoadProgress::initTestCase()
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoadProgress::test_loadProgress()
PASS   : TouchWebViewLoadProgress::cleanupTestCase()
PASS   : TouchWebViewLoadProgressSignal::initTestCase()
QWARN  : TouchWebViewLoadProgressSignal::test_loadProgressSignal()
QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoadProgressSignal::test_loadProgressSignal()
PASS   : TouchWebViewLoadProgressSignal::cleanupTestCase()
PASS   : TouchWebViewLoad::initTestCase()
QWARN  : TouchWebViewLoad::test_loadZeroSizeView() QSocketNotifier: socket
notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoad::test_loadZeroSizeView()
PASS   : TouchWebViewLoad::cleanupTestCase()
PASS   : TouchWebViewProperties::initTestCase()
QWARN  : TouchWebViewProperties::test_title() QSocketNotifier: socket notifiers
cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewProperties::test_title()
PASS   : TouchWebViewProperties::test_url()
PASS   : TouchWebViewProperties::cleanupTestCase()
Totals: 33 passed, 0 failed, 0 skipped
********* Finished testing of qmltests *********