[webkit-reviews] review granted: [Bug 65309] [Qt] [WK2] Implement a persistent cookie storage. : [Attachment 107998] Patch

[bugzilla-daemon at webkit.org]

Chang Shu <cshu at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 65309: [Qt] [WK2] Implement a persistent cookie storage.
https://bugs.webkit.org/show_bug.cgi?id=65309

Attachment 107998: Patch
https://bugs.webkit.org/attachment.cgi?id=107998&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107998&action=review


just have some minor questions. address them if they make sense, otherwise,
just cq+. thx

> Source/WebCore/platform/qt/CookieJarQt.cpp:204
> +    QList<QNetworkCookie>::Iterator end = cookies.end();

can just move cookies.end() in while().

> Source/WebCore/platform/qt/CookieJarQt.cpp:244
> +    bool status = QNetworkCookieJar::setCookiesFromUrl(cookieList, url);

do we have to do all the stuff below when status==false?

> Source/WebCore/platform/qt/CookieJarQt.cpp:263
> +    if (!m_database.open()) {

not sure if we have to check the state of m_database every time we use it.