[webkit-reviews] review denied: [Bug 68351] [chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element. : [Attachment 107840] patch for bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 10:41:06 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied chandra shekar
vallala <chandra.vallala at motorola.com>'s request for review:
Bug 68351: [chromium]ClearFocusedNode doesn't clear the cursor or selection in
editable div element.
https://bugs.webkit.org/show_bug.cgi?id=68351

Attachment 107840: patch for bug
https://bugs.webkit.org/attachment.cgi?id=107840&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107840&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:1806
> +	   || (oldFocusedNode->hasTagName(HTMLNames::divTag)

Any block element can be made content editable.  Checking only for a DIV tag
seems a bit too restrictive.


More information about the webkit-reviews mailing list