[webkit-reviews] review denied: [Bug 68350] APIClient::initialize does not build with newer gcc : [Attachment 107839] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 68350: APIClient::initialize does not build with newer gcc
https://bugs.webkit.org/show_bug.cgi?id=68350

Attachment 107839: Patch
https://bugs.webkit.org/attachment.cgi?id=107839&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
It looks like this restructuring will give bad behavior in a non-debug build if
the client passed in is of a newer version than is expected. Previously that
would result in m_client being initialized to zero. Now it’ll attempt to memcpy
the size of the version passed in, which will be undefined… That seems bad?