[webkit-reviews] review canceled: [Bug 67080] Add unit test for existing StringBuilder : [Attachment 107806] patch tentatively fixes windows build break

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 01:06:00 PDT 2011


Xianzhu Wang <wangxianzhu at chromium.org> has canceled Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 67080: Add unit test for existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67080

Attachment 107806: patch tentatively fixes windows build break
https://bugs.webkit.org/attachment.cgi?id=107806&action=review

------- Additional Comments from Xianzhu Wang <wangxianzhu at chromium.org>
Adding the symbols breaks WebCore build on Windows. Saw AtomicString.cpp,
StringImpl.cpp and WTFString.cpp explicitly included in WebCore.vcproj, so it
seems that the symbols of them are intentionally not exported from
JavaScriptCore. Should I add the three files into TestWebKitAPI.vcproj?


More information about the webkit-reviews mailing list