[webkit-reviews] review denied: [Bug 67789] Web Inspector: extract RawSourceCode source mapping logic to helper classes. : [Attachment 106762] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 00:40:08 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 67789: Web Inspector: extract RawSourceCode source mapping logic to helper
classes.
https://bugs.webkit.org/show_bug.cgi?id=67789

Attachment 106762: Patch
https://bugs.webkit.org/attachment.cgi?id=106762&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106762&action=review


> Source/WebCore/inspector/front-end/SourceFile.js:225
> +WebInspector.RawSourceCode.FormattedSourceMapping = function(rawSourceCode,
uiSourceCode, mapping)

Why does formatted source mapping live under the raw source code? I was
expecting formatting to be a part of the UI* hierarchy.


More information about the webkit-reviews mailing list