[webkit-reviews] review denied: [Bug 67884] Delete button icon does not properly update when the device resolution changes dynamically : [Attachment 107562] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 67884: Delete button icon does not properly update when the device
resolution changes dynamically
https://bugs.webkit.org/show_bug.cgi?id=67884

Attachment 107562: Patch
https://bugs.webkit.org/attachment.cgi?id=107562&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107562&action=review


> Source/WebCore/ChangeLog:15
> +	   takes an optional bool parameter indicated whether or not the change
affects the 
> +	   Editor since page scale changes don't affect Editor.

It seems like the bool parameter indicates whether it’s the device scale factor
changing or the page scale factor changing. Calling it “affectsEditor” seems
kind of wrong.

Instead of adding a bool and attaching the deviceScaleFactorChanged work into
the existing function, I suggest putting the code to iterate all the frames and
call deviceScaleFactorChanged on each editor directly into
Page::setDeviceScaleFactor. You wouldn’t have to touch Frame.h/cpp at all.
Iterating all the frames in a page is simple and can be done without recursion.