[webkit-reviews] review granted: [Bug 67510] Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction : [Attachment 107559] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 67510: Crash can occur when doing a PlatformCAAnimation::copy() with no
valueFunction
https://bugs.webkit.org/show_bug.cgi?id=67510

Attachment 107559: Patch
https://bugs.webkit.org/attachment.cgi?id=107559&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107559&action=review


Very nice!

> Source/WebCore/platform/win/StructuredExceptionHandlerSupressor.h:51
> +	   __asm mov eax, 0xffffffff
> +	   __asm mov FS:[0], EAX

eax vs. EAX; which one? (Ditto on lines 48 and 49.)

> Source/WebCore/platform/win/StructuredExceptionHandlerSupressor.h:59
> +	   __asm mov EAX, [m_savedExceptionRegistration]

Weird that you can read from but not write to member variables.