[webkit-reviews] review granted: [Bug 68099] [V8] Null v8::Context crash in V8DOMWindowShell::namedItemAdded() : [Attachment 107409] patch - fixed inverted logic and attempted cr-mac build fix

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 68099: [V8] Null v8::Context crash in V8DOMWindowShell::namedItemAdded()
https://bugs.webkit.org/show_bug.cgi?id=68099

Attachment 107409: patch - fixed inverted logic and attempted cr-mac build fix
https://bugs.webkit.org/attachment.cgi?id=107409&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107409&action=review


> Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:574
> +	   // FIXME: Temporary diagnostics as to why V8 sometimes crashes with
a null context below.

Technically we should either skip the FIXME or re-word this to explain when we
should remove this code.