[webkit-reviews] review granted: [Bug 67952] Ask for audio hardware buffer size instead of using hardwired constants. : [Attachment 107400] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Raymond Toy <rtoy at chromium.org>'s
request for review:
Bug 67952: Ask for audio hardware buffer size instead of using hardwired
constants.
https://bugs.webkit.org/show_bug.cgi?id=67952

Attachment 107400: Patch
https://bugs.webkit.org/attachment.cgi?id=107400&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107400&action=review


This looks fine overall, but it has to wait to land until the downstream
Chromium code implementing the new entry point has been checked in. At that
point, Source/WebKit/chromium/DEPS will presumably need to be rolled forward.
If so, then I'd suggest incorporating that roll into this patch so the
dependencies are clearer.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:72
> +    ASSERT(m_callbackBufferSize <= maximumCallbackBufferSize);

Is asserting really the best behavior in this case, rather than for example
clamping to the maximum callback buffer size?