[webkit-reviews] review denied: [Bug 67952] Ask for audio hardware buffer size instead of using hardwired constants. : [Attachment 107216] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Raymond Toy
<rtoy at chromium.org>'s request for review:
Bug 67952: Ask for audio hardware buffer size instead of using hardwired
constants.
https://bugs.webkit.org/show_bug.cgi?id=67952

Attachment 107216: Patch
https://bugs.webkit.org/attachment.cgi?id=107216&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107216&action=review


> Source/WebKit/chromium/public/WebKitPlatformSupport.h:310
>      virtual double audioHardwareSampleRate() { return 0; }

It seems like we are growing enough audio specific functions here to perhaps
justify defining a WebAudioSupport interface.  This is a larger refactoring
though, and it doesn't have to be a pre-requisite for this patch.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:66
> +    m_callbackBufferSize =
webKitPlatformSupport()->audioHardwareBufferSize();

nit: I think it is a bit awkward to use this member variable to store the
audioHardwareBufferSize result.  It seems like it would be better to create a
local variable for this.