[webkit-reviews] review denied: [Bug 67733] [Chromium] Separate WebKit initialization and V8 initialization in chromium port : [Attachment 107202] Style

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 67733: [Chromium] Separate WebKit initialization and V8 initialization in
chromium port
https://bugs.webkit.org/show_bug.cgi?id=67733

Attachment 107202: Style
https://bugs.webkit.org/attachment.cgi?id=107202&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107202&action=review


> Source/WebKit/chromium/public/WebKit.h:40
> +enum ShouldInitializeV8 {

nit: We use a specific naming convention for enums in the WebKit API:

  enum Foo {
     FooA,
     FooB
  };

The values are prefixed with the type name in other words.

Also, we prefix types with "Web" unless they are defined within a class.

However, this suggests something fairly awkward
(WebKitV8InitializationOptions), which makes me sad.

Perhaps a better function is to have two functions:

  WEBKIT_EXPORT void initialize(WebKitPlatformSupport*);
  WEBKIT_EXPORT void initializeWithoutV8(WebKitPlatformSupport*);

Then, in the implementation we can have initialize call initializeWithoutV8
followed by the code
to actually initialize V8.